[ui] Bugfixes for asset tags #20723
Merged
[ui] Bugfixes for asset tags #20723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @clairelin135 and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f0d5251. |
clairelin135
force-pushed
the
03-25-claire/fix-filter-by-tag
branch
from
a8f7f18 to
a2e3405
Compare
clairelin135
changed the title
salazarm
reviewed
Mar 25, 2024
| <Tag key={idx}> | ||
| {tag.key}={tag.value} | ||
| </Tag> | ||
| <Tag key={idx}>{buildTagString({key: tag.key, value: tag.value})}</Tag> |
salazarm
reviewed
Mar 25, 2024
| @@ -37,7 +37,7 @@ export const useAssetTagFilter = ({ | |||
| /> | |||
| ); | |||
| }, | |||
| getStringValue: ({value, key}) => `${value}: ${key}`, | |||
| getStringValue: ({value, key}) => `${key}: ${value}`, | |||
salazarm
reviewed
Mar 25, 2024
| @@ -81,6 +81,6 @@ export function doesFilterArrayMatchValueArray<T, V>( | |||
| return !filterArray.some( | |||
| (filterTag) => | |||
| // If no asset tags match this filter tag return true | |||
| !valueArray.find((value) => !isMatch(filterTag, value)), | |||
| !valueArray.find((value) => isMatch(filterTag, value)), | |||
There was a problem hiding this comment.
this function is used by other filters, can you confirm those still work?
There was a problem hiding this comment.
I think its only used for owners and tags, this implementation works for both
salazarm
approved these changes
Mar 26, 2024
clairelin135
force-pushed
the
03-25-claire/rename-asset-catalog-overview
branch
from
9b9c637 to
c4d72d8
Compare
Base automatically changed from
03-25-claire/rename-asset-catalog-overview
to
master
March 26, 2024 16:20
clairelin135
force-pushed
the
03-25-claire/fix-filter-by-tag
branch
from
a2e3405 to
8cd3fe1
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
Fixes a few bugs: - Makes filter value display with `key: value` instead of `value: key` - Removes an extra `!` operator to fix filtering - Adjusts asset overview page to hide `__dagster_no_value` tag values <img width="1278" alt="image" src="https://github.com/dagster-io/dagster/assets/29110579/fc15029a-88eb-4978-be01-e50c52f2422b"> <img width="1280" alt="image" src="https://github.com/dagster-io/dagster/assets/29110579/2aa51cbc-2566-4387-a9f6-2031c4ab7e52">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs:
key: valueinstead ofvalue: key!operator to fix filtering__dagster_no_valuetag values