[ui] Add font-weight range to Geist definitions #21354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
braunjj
approved these changes
Apr 23, 2024
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit b1e24ef. |
nikomancy
pushed a commit
to nikomancy/dagster
that referenced
this pull request
May 1, 2024
## Summary & Motivation Needed to define `font-weight` as a range for our `@font-face` declarations for Geist. ## How I Tested These Changes Load app in Safari, Chrome, FF. Verify that fonts in nav and tabs look correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Needed to define
font-weightas a range for our@font-facedeclarations for Geist.How I Tested These Changes
Load app in Safari, Chrome, FF. Verify that fonts in nav and tabs look correct.