Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo client take 2 #21361

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Update apollo client take 2 #21361

merged 12 commits into from
Apr 24, 2024

Conversation

salazarm
Copy link
Contributor

Summary & Motivation

Redo of #21292 with no changes

@salazarm salazarm requested review from bengotow and hellendag April 23, 2024 13:54
Copy link

github-actions bot commented Apr 23, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-oertwtcqo-elementl.vercel.app
https://salazarm-update-apollo-client-2.core-storybook.dagster-docs.io

Built with commit ada91f7.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm force-pushed the salazarm/update-apollo-client-2 branch from 64aa5eb to fe6f3e4 Compare April 23, 2024 14:13
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I think every apollo update we've applied has changed behavior unexpectedly, we should definitely be on the lookout for any weird behavior following this update.

Copy link

github-actions bot commented Apr 23, 2024

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-d07rplfyc-elementl.vercel.app
https://salazarm-update-apollo-client-2.components-storybook.dagster-docs.io

Built with commit ada91f7.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm merged commit 00971e2 into master Apr 24, 2024
3 checks passed
@salazarm salazarm deleted the salazarm/update-apollo-client-2 branch April 24, 2024 20:53
nikomancy pushed a commit to nikomancy/dagster that referenced this pull request May 1, 2024
## Summary & Motivation
Redo of dagster-io#21292 with no changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants