[ui] Hide Overview tabs for nav flag #21367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4bd5409. |
bengotow
approved these changes
Apr 24, 2024
Merge activity
|
graphite-app
bot
added
the
area: dagster-university
hellendag
force-pushed
the
dish/overview-tabs-flagged
branch
from
b0d0333 to
4bd5409
Compare
nikomancy
pushed a commit
to nikomancy/dagster
that referenced
this pull request
May 1, 2024
## Summary & Motivation Within the Navigation/Settings flag: - For most "Overview" routes, perform a redirect away from `/overview/...` - Hide tabs that are now surfaced in the top nav (Jobs, Automation) ## How I Tested These Changes View app inside and outside of flag. Verify that redirects behave correctly when flagged, and verify that tabs look and behave correct in both flag states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Within the Navigation/Settings flag:
/overview/...How I Tested These Changes
View app inside and outside of flag. Verify that redirects behave correctly when flagged, and verify that tabs look and behave correct in both flag states.