Make command clicking on a node in asset lineage graph open it in a new page #21456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
reviewed
Apr 30, 2024
Comment on lines
173
to
176
| <AssetNode | ||
| definition={graphNode.definition} | ||
| selected={graphNode.id === assetGraphId} | ||
| /> |
There was a problem hiding this comment.
I think we hadn't done this previously because this AssetNode contains links, and the DOM doesn't allow <a> tags within <a> tags :( At least, it was making React spew logs about invalid nesting.
There was a problem hiding this comment.
hmm interesting, I guess I could read e.metaKey and keep it in JS
alangenfeld
approved these changes
May 15, 2024
salazarm
force-pushed
the
marco/fe-333-cmd-clicking-on-an-asset-in-the-lineage-graph-should-open-a
branch
from
b5d9cd5 to
a58e6ce
Compare
…333-cmd-clicking-on-an-asset-in-the-lineage-graph-should-open-a
salazarm
deleted the
marco/fe-333-cmd-clicking-on-an-asset-in-the-lineage-graph-should-open-a
branch
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
…ew page (#21456) ## Summary & Motivation Adding real links here to do this rather than using a JS click handler. ## How I Tested These Changes https://github.com/dagster-io/dagster/assets/2286579/bee9eb20-cd0b-4f0f-8e8b-df2467ea5b23
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…ew page (dagster-io#21456) ## Summary & Motivation Adding real links here to do this rather than using a JS click handler. ## How I Tested These Changes https://github.com/dagster-io/dagster/assets/2286579/bee9eb20-cd0b-4f0f-8e8b-df2467ea5b23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adding real links here to do this rather than using a JS click handler.
How I Tested These Changes
Screen.Recording.2024-04-26.at.1.57.05.PM.mov