Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Replace uses of replaceAlpha in asset graph, not possible with new vars #21589

Merged
merged 1 commit into from
May 2, 2024
Merged

[ui] Replace uses of replaceAlpha in asset graph, not possible with new vars #21589

merged 1 commit into from
May 2, 2024

Conversation

bengotow
Copy link
Collaborator

@bengotow bengotow commented May 2, 2024

Fixes FE-341

Summary & Motivation

How I Tested These Changes

@bengotow bengotow requested a review from salazarm May 2, 2024 15:02
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-k6yxscuuy-elementl.vercel.app
https://bengotow-2024-05-FE-341.core-storybook.dagster-docs.io

Built with commit 24cc922.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-i58ssnjgt-elementl.vercel.app
https://bengotow-2024-05-FE-341.components-storybook.dagster-docs.io

Built with commit 24cc922.
This pull request is being automatically deployed with vercel-action

salazarm
salazarm approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind posting a video of the animations working?

@bengotow bengotow force-pushed the bengotow-2024-05/FE-341 branch from 8371021 to 24cc922 Compare May 2, 2024 15:27
@bengotow
Copy link
Collaborator Author

bengotow commented May 2, 2024

Yep definitely - here's what it looks like now. I think this is right @salazarm? https://www.loom.com/share/7058f3de75a44ca4a215ec95fef81084

@salazarm
Copy link
Contributor

salazarm commented May 2, 2024

yeah lgtm. the storybook is broken :( https://bengotow-2024-05-fe-341.core-storybook.dagster-docs.io/?path=/story/asset-graph-assetnode--live-states

@bengotow
Copy link
Collaborator Author

bengotow commented May 2, 2024

Ahh hrmm, i'll take a look at the storybookr real quick - looks like that's probably been broken for a while if it's mad about liveData :/

@bengotow bengotow merged commit 22f7ac9 into master May 2, 2024
5 checks passed
@bengotow bengotow deleted the bengotow-2024-05/FE-341 branch May 2, 2024 21:40
cmpadden pushed a commit that referenced this pull request May 6, 2024
@bengotow @cmpadden
[ui] Replace uses of replaceAlpha in asset graph, not possible with n…
811a7b0 
…ew vars (#21589)

Fixes FE-341

## Summary & Motivation

## How I Tested These Changes

Co-authored-by: bengotow <[email protected]>
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
@bengotow @danielgafni
[ui] Replace uses of replaceAlpha in asset graph, not possible with n…
32e91c8 
…ew vars (dagster-io#21589)

Fixes FE-341

## Summary & Motivation

## How I Tested These Changes

Co-authored-by: bengotow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salazarm salazarm salazarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengotow @salazarm