[ui] Save sensor type, instigation type, backfill status filters to URL #21611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5f7361f. |
salazarm
approved these changes
May 2, 2024
bengotow
force-pushed
the
bengotow-2024-05/FE-330
branch
from
6eca921 to
5f7361f
Compare
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
…RL (#21611) ## Summary & Motivation This PR resolves FM-330 and fixes several other related problems. The following are now saved to the URL instead of just locally on the page. These are all the ones I could find - as far as I can tell we're saving to the URL everywhere now. I think it'd be nice to explore changing the filter hooks so that uncontrolled usage is not allowed, or it falls back to URL storage on it's own. - Search value on "Deployment > Resources" - "Running state" on "Overview > Schedules" and "Deployment > Schedules" - "Running state" on "Overview > Sensors" and "Deployment > Sensors" - "Sensor type" on "Overview > Sensors" - "Status" on "Overview > Backfills" The one remaining odd bit is that the Repo pickers are typically saving to local storage / workspace context instead of the URL, so those filter states aren't entirely shareable. ## How I Tested These Changes Enabled / disabled each filter on the impacted pages Co-authored-by: bengotow <[email protected]>
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…RL (dagster-io#21611) ## Summary & Motivation This PR resolves FM-330 and fixes several other related problems. The following are now saved to the URL instead of just locally on the page. These are all the ones I could find - as far as I can tell we're saving to the URL everywhere now. I think it'd be nice to explore changing the filter hooks so that uncontrolled usage is not allowed, or it falls back to URL storage on it's own. - Search value on "Deployment > Resources" - "Running state" on "Overview > Schedules" and "Deployment > Schedules" - "Running state" on "Overview > Sensors" and "Deployment > Sensors" - "Sensor type" on "Overview > Sensors" - "Status" on "Overview > Backfills" The one remaining odd bit is that the Repo pickers are typically saving to local storage / workspace context instead of the URL, so those filter states aren't entirely shareable. ## How I Tested These Changes Enabled / disabled each filter on the impacted pages Co-authored-by: bengotow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR resolves FM-330 and fixes several other related problems. The following are now saved to the URL instead of just locally on the page. These are all the ones I could find - as far as I can tell we're saving to the URL everywhere now. I think it'd be nice to explore changing the filter hooks so that uncontrolled usage is not allowed, or it falls back to URL storage on it's own.
The one remaining odd bit is that the Repo pickers are typically saving to local storage / workspace context instead of the URL, so those filter states aren't entirely shareable.
How I Tested These Changes
Enabled / disabled each filter on the impacted pages