Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nextjs v13 to v14 #22152

Closed
wants to merge 3 commits into from
Closed

Upgrade nextjs v13 to v14 #22152

wants to merge 3 commits into from

Conversation

nikomancy
Copy link
Contributor

Summary & Motivation

Upgrading Next.js to enable handling several features of the MDX-transform make script as automatic parts of Markdoc's transform step.

How I Tested These Changes

Ran on local. No build errors. No visible issues on a sample of Markdoc based and MDX based pages.

@graphite-app graphite-app bot added the area: docs Related to documentation in general label May 29, 2024
@PedramNavid
Copy link
Contributor

Looks like some dependency issues as well:

Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

- Fixing missing peer dependencies
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-jxqtfwjr5-elementl.vercel.app
https://upgrade-nextjs-v13-to-v14.dagster.dagster-docs.io

Direct link to changed pages:

@nikomancy
Copy link
Contributor Author

Closing this PR due to blockers with Buildkite and an unclear pathway to fix them. It looks like the Next version was bumped to 14+ on Master by another PR so the main goal of this PR has been accomplished.

@nikomancy nikomancy closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants