Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add table metadata docs #22291

Merged
merged 4 commits into from
Jun 7, 2024
Merged

[docs] Add table metadata docs #22291

merged 4 commits into from
Jun 7, 2024

Conversation

benpankow
Copy link
Member

Summary

Adds docs on how to add new tabular metadata to your assets.

Test Plan

vercel + local docs

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jun 4, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 June 4, 2024 22:34
@benpankow
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@benpankow benpankow force-pushed the benpankow/add-table-metadata branch from cfcde45 to d391729 Compare June 4, 2024 22:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-ancsiv07s-elementl.vercel.app
https://benpankow-add-table-metadata.dagster.dagster-docs.io

Direct link to changed pages:

@benpankow benpankow requested a review from sryza June 4, 2024 22:59
sryza
sryza previously requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated

### For assets loaded from integrations

Column schemas are currently supported in the dbt integration. Refer to the [dbt documentation](/integrations/dbt/reference) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be a little more specific: something like "Dagster's dbt integration supports automatically attaching column schema metadata to assets".

Also, is there a more direct subheading we could link to on that page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it this?

https://docs.dagster.io/integrations/dbt/reference#fetching-column-level-lineage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or https://docs.dagster.io/integrations/dbt/reference#customizing-metadata - this section mentions it as definition-level metadata (the above is materialization-time)

docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
erinkcochran87
erinkcochran87 reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

docs/content/concepts/metadata-tags/asset-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Outdated Show resolved Hide resolved
docs/content/concepts/metadata-tags/asset-metadata/table-metadata.mdx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-5yvn9gouk-elementl.vercel.app
https://benpankow-add-table-metadata.core-storybook.dagster-docs.io

Built with commit a96329c.
This pull request is being automatically deployed with vercel-action

@benpankow benpankow requested review from sryza and erinkcochran87 June 5, 2024 19:56
@benpankow benpankow force-pushed the benpankow/add-table-metadata branch 3 times, most recently from 95650f3 to 21385ba Compare June 6, 2024 20:15
erinkcochran87
erinkcochran87 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so so good @benpankow - ship it out! 🚢

@benpankow benpankow force-pushed the benpankow/add-table-metadata branch from b2ce3cb to b5ebf79 Compare June 7, 2024 17:48
@benpankow benpankow merged commit a804e08 into master Jun 7, 2024
2 checks passed
@benpankow benpankow deleted the benpankow/add-table-metadata branch June 7, 2024 18:12
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
@benpankow @danielgafni
[docs] Add table metadata docs (dagster-io#22291)
a0a96aa 
## Summary

Adds docs on how to add new tabular metadata to your assets.

## Test Plan

vercel + local docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinkcochran87 erinkcochran87 erinkcochran87 approved these changes

@sryza sryza Awaiting requested review from sryza

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benpankow @sryza @erinkcochran87