feat(catalog): visualize compute and storage kind tags in asset search results #22298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 13a7361. |
|
I feel like the icons are too large but cc @braunjj for design feedback |
rexledesma
force-pushed
the
rl/add-tags-to-search-results
branch
2 times, most recently
from
2fea232 to
310132c
Compare
rexledesma
force-pushed
the
rl/add-tags-to-search-results
branch
from
310132c to
421f7a1
Compare
rexledesma
changed the title
rexledesma
force-pushed
the
rl/add-tags-to-search-results
branch
2 times, most recently
from
f643d3a to
29bd967
Compare
rexledesma
force-pushed
the
rl/add-tags-to-search-results
branch
from
29bd967 to
385c7db
Compare
rexledesma
changed the title
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…h results (dagster-io#22298) ## Summary & Motivation Use the asset's visual icons (compute/storage kind) to give more flavor to the asset's search result display. This way, users can start to differentiate results from a glance, rather than thoroughly inspecting the fuzzy match and full asset key name. ## How I Tested These Changes local ### Before <img width="813" alt="Screenshot 2024-06-07 at 1 21 47 PM" src="https://github.com/dagster-io/dagster/assets/16431325/ccc49646-eb94-4599-a5c8-e3d2e3d2196c"> ### After <img width="809" alt="Screenshot 2024-06-07 at 1 20 59 PM" src="https://github.com/dagster-io/dagster/assets/16431325/247b1c1a-4d5e-421b-9d8e-eb26267b5fe7"> ### For compute kinds without a special tag <img width="1350" alt="Screenshot 2024-06-07 at 2 30 23 PM" src="https://github.com/dagster-io/dagster/assets/16431325/c4d27b08-b642-4278-a4e9-6372968e8855">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Use the asset's visual icons (compute/storage kind) to give more flavor to the asset's search result display. This way, users can start to differentiate results from a glance, rather than thoroughly inspecting the fuzzy match and full asset key name.
How I Tested These Changes
local
Before
After
For compute kinds without a special tag