Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add brief storage kind docs #22328

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

benpankow
Copy link
Member

Summary

Adds a brief docs section about storage kind tags. I notice we don't have a similar section for compute kind - maybe we should wait until after these can be asset tags (#22188)

Test Plan

vercel

@graphite-app graphite-app bot requested a review from erinkcochran87 June 6, 2024 16:54
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jun 6, 2024
@benpankow benpankow requested a review from sryza June 6, 2024 16:54
@benpankow
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but otherwise lgtm! 🚀

docs/content/concepts/metadata-tags/tags.mdx Outdated Show resolved Hide resolved
@benpankow benpankow merged commit deee4e3 into master Jun 7, 2024
1 of 2 checks passed
@benpankow benpankow deleted the benpankow/storage-kind-docs branch June 7, 2024 17:11
benpankow added a commit that referenced this pull request Jun 7, 2024
benpankow added a commit that referenced this pull request Jun 7, 2024
## Summary

Reverts storage kind docs in case we want to adjust their APIs
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary

Adds a brief docs section about storage kind tags. I notice we don't
have a similar section for compute kind - maybe we should wait until
after these can be asset tags (dagster-io#22188)

## Test Plan

vercel

---------

Co-authored-by: Erin Cochran <[email protected]>
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
…er-io#22367)

## Summary

Reverts storage kind docs in case we want to adjust their APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants