Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_assets_from_dbt_manifest #22387

Closed
wants to merge 1 commit into from

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Jun 8, 2024

Summary & Motivation

There are 16 deprecated params to load_assets_from_dbt_manifest. Let's hide them

How I Tested These Changes

BK. Look at docs.

Copy link
Member Author

schrockn commented Jun 8, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @schrockn and the rest of your teammates on Graphite Graphite

@schrockn schrockn force-pushed the hide-super-deprecated-arg branch from e94536b to 9d59d4f Compare June 8, 2024 16:05
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch 2 times, most recently from f0f9576 to 7549722 Compare June 8, 2024 18:36
@schrockn schrockn requested review from rexledesma, sryza and yuhan June 8, 2024 18:38
@schrockn schrockn marked this pull request as ready for review June 8, 2024 18:38
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jun 8, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 June 8, 2024 18:38
Copy link

github-actions bot commented Jun 8, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-3v9y34ttd-elementl.vercel.app
https://hide-dbt-manifest-args.dagster.dagster-docs.io

Direct link to changed pages:

@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from 7549722 to 12aa0e7 Compare June 8, 2024 21:10
@schrockn schrockn mentioned this pull request Jun 8, 2024
@schrockn schrockn force-pushed the hide-super-deprecated-arg branch from 9d59d4f to 7d64967 Compare June 22, 2024 14:41
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from 12aa0e7 to fc58ac3 Compare June 22, 2024 14:41
@schrockn schrockn changed the base branch from hide-super-deprecated-arg to explicit-hidden-param-decorator June 22, 2024 14:41
Base automatically changed from explicit-hidden-param-decorator to hide-super-deprecated-arg June 22, 2024 14:41
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from fc58ac3 to 28df230 Compare June 22, 2024 14:51
@schrockn schrockn force-pushed the hide-super-deprecated-arg branch from f3af5c9 to 6056f43 Compare June 22, 2024 15:46
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from 28df230 to 2c59e04 Compare June 22, 2024 15:46
@erinkcochran87 erinkcochran87 removed their request for review June 24, 2024 15:33
@erinkcochran87 erinkcochran87 removed the area: docs Related to documentation in general label Jun 24, 2024
@schrockn schrockn force-pushed the hide-super-deprecated-arg branch from 6056f43 to d81e840 Compare July 18, 2024 17:11
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from f4ac370 to ce0e729 Compare July 18, 2024 17:11
@rexledesma rexledesma removed their request for review September 12, 2024 15:07
@schrockn schrockn marked this pull request as draft September 16, 2024 18:33
cp

cp

cp
@schrockn schrockn force-pushed the hide-super-deprecated-arg branch from d81e840 to c3d48b1 Compare October 17, 2024 16:55
@schrockn schrockn force-pushed the hide-dbt-manifest-args branch from ce0e729 to 3018593 Compare October 17, 2024 16:55
@schrockn schrockn closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants