Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties. #22407

Closed
wants to merge 1 commit into from

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Jun 9, 2024

Summary & Motivation

In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties.

How I Tested These Changes

BK

Copy link
Member Author

schrockn commented Jun 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-2 branch from 30083c0 to 4c452fb Compare June 9, 2024 19:19
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch 2 times, most recently from 8160e90 to b0d53e5 Compare June 9, 2024 19:33
@schrockn schrockn changed the base branch from asset-check-ctor-refactor-stack-2 to asset-check-ctor-refactor-stack-1.7 June 9, 2024 19:33
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch 2 times, most recently from 2fb2d59 to defd56a Compare June 9, 2024 19:56
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-1.7 branch from 4161273 to 70d39c5 Compare June 10, 2024 00:33
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch 2 times, most recently from 14888dd to ea4a864 Compare June 10, 2024 00:34
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-1.7 branch from 405c492 to 56558b4 Compare June 10, 2024 00:45
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch 2 times, most recently from d891ae9 to 3a5b3bf Compare June 10, 2024 00:52
@schrockn schrockn changed the base branch from asset-check-ctor-refactor-stack-1.7 to typed-list-param June 10, 2024 00:52
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from 3a5b3bf to f2da3ae Compare June 10, 2024 00:55
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from f2da3ae to 7d85bf6 Compare June 10, 2024 00:57
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from 7d85bf6 to 52d2736 Compare June 10, 2024 00:58
@schrockn schrockn changed the title make create trivial In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties. Jun 10, 2024
@schrockn schrockn requested review from smackesey and sryza June 10, 2024 11:36
@schrockn schrockn marked this pull request as ready for review June 10, 2024 11:36
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from 52d2736 to 1deb8bf Compare June 10, 2024 12:09
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from 1deb8bf to 7d8d774 Compare June 12, 2024 13:36
Base automatically changed from typed-list-param to master June 12, 2024 14:33
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from 7d8d774 to e4ce65b Compare June 13, 2024 23:35
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from e4ce65b to c21f43b Compare June 22, 2024 14:27
@schrockn schrockn force-pushed the asset-check-ctor-refactor-stack-3 branch from c21f43b to 40fa106 Compare July 15, 2024 22:45
@schrockn schrockn closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant