-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties. #22407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2024
Merged
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-2
branch
from
June 9, 2024 19:19
30083c0
to
4c452fb
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
2 times, most recently
from
June 9, 2024 19:33
8160e90
to
b0d53e5
Compare
schrockn
changed the base branch from
asset-check-ctor-refactor-stack-2
to
asset-check-ctor-refactor-stack-1.7
June 9, 2024 19:33
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
2 times, most recently
from
June 9, 2024 19:56
2fb2d59
to
defd56a
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-1.7
branch
from
June 10, 2024 00:33
4161273
to
70d39c5
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
2 times, most recently
from
June 10, 2024 00:34
14888dd
to
ea4a864
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-1.7
branch
from
June 10, 2024 00:45
405c492
to
56558b4
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
2 times, most recently
from
June 10, 2024 00:52
d891ae9
to
3a5b3bf
Compare
schrockn
changed the base branch from
asset-check-ctor-refactor-stack-1.7
to
typed-list-param
June 10, 2024 00:52
schrockn
force-pushed
the
typed-list-param
branch
from
June 10, 2024 00:55
1cea005
to
01a5ac0
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 10, 2024 00:55
3a5b3bf
to
f2da3ae
Compare
schrockn
force-pushed
the
typed-list-param
branch
from
June 10, 2024 00:57
01a5ac0
to
d309c5e
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 10, 2024 00:57
f2da3ae
to
7d85bf6
Compare
schrockn
force-pushed
the
typed-list-param
branch
from
June 10, 2024 00:58
d309c5e
to
ed157e4
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 10, 2024 00:58
7d85bf6
to
52d2736
Compare
This was referenced Jun 10, 2024
schrockn
changed the title
make create trivial
In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties.
Jun 10, 2024
schrockn
force-pushed
the
typed-list-param
branch
from
June 10, 2024 12:08
ed157e4
to
c0f5ca6
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 10, 2024 12:09
52d2736
to
1deb8bf
Compare
This was referenced Jun 10, 2024
schrockn
force-pushed
the
typed-list-param
branch
from
June 12, 2024 13:35
c0f5ca6
to
88c2d85
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 12, 2024 13:36
1deb8bf
to
7d8d774
Compare
This was referenced Jun 12, 2024
schrockn
force-pushed
the
typed-list-param
branch
from
June 12, 2024 14:31
88c2d85
to
2fe738d
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 13, 2024 23:35
7d8d774
to
e4ce65b
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
June 22, 2024 14:27
e4ce65b
to
c21f43b
Compare
schrockn
force-pushed
the
asset-check-ctor-refactor-stack-3
branch
from
July 15, 2024 22:45
c21f43b
to
40fa106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In preparation for moving AssetChecksDefinition.create into the builder, make it trivially use builder properties.
How I Tested These Changes
BK