Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daggy-u] fix indentation of indented code snippets #22571

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

cmpadden
Copy link
Contributor

Summary & Motivation

  • Fixes indentation of code snippets for indented code blocks

How I Tested These Changes

  • Previewed rendered markdown
image

@cmpadden cmpadden requested a review from erinkcochran87 June 17, 2024 15:04
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Jun 17, 2024
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-giuheqpez-elementl.vercel.app
https://colton-docs-du-dbt-fix-code-indent.dagster.dagster-docs.io

Direct link to changed pages:

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indents look good to me, just one thing to look at with the callout in this section

@cmpadden cmpadden merged commit 4436320 into master Jun 20, 2024
2 checks passed
@cmpadden cmpadden deleted the colton/docs-du-dbt-fix-code-indent branch June 20, 2024 18:59
cmpadden added a commit that referenced this pull request Jun 24, 2024
## Summary & Motivation

- Fixes indentation of code snippets for indented code blocks

## How I Tested These Changes

- Previewed rendered markdown

<img width="1106" alt="image"
src="https://github.com/dagster-io/dagster/assets/5807118/148b214a-318e-47f9-87e1-77ed302348aa">
cmpadden added a commit that referenced this pull request Jun 24, 2024
## Summary & Motivation

- Fixes indentation of code snippets for indented code blocks

## How I Tested These Changes

- Previewed rendered markdown

<img width="1106" alt="image"
src="https://github.com/dagster-io/dagster/assets/5807118/148b214a-318e-47f9-87e1-77ed302348aa">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants