Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[daggy-u] instruct users to install dagster 1.7 in course #22790

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[daggy-u] instruct users to install dagster 1.7 in course #22790

merged 1 commit into from
Jul 1, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Jul 1, 2024

No description provided.

@cmpadden cmpadden requested a review from erinkcochran87 July 1, 2024 15:01
@graphite-app graphite-app bot added the area: dagster-university Related to Dagster University label Jul 1, 2024
gibsondan
gibsondan approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the setup.py also does not include "fastparquet" anymore

Should we have a unit test that makes sure the two files are in sync?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-buh5po0st-elementl.vercel.app
https://colton-daggy-u-dbt-1-7.dagster-university.dagster-docs.io

Built with commit bd7bbc9.
This pull request is being automatically deployed with vercel-action

@cmpadden
Copy link
Contributor Author

cmpadden commented Jul 1, 2024

the setup.py also does not include "fastparquet" anymore

Should we have a unit test that makes sure the two files are in sync?

Interesting - I was under the impression that the user would still need fastparquet.

But I am in favor of adding a unit test to validate this kind of thing; or figure out how to embed the real setup.py file code snippet.

@cmpadden cmpadden merged commit fa2c660 into master Jul 1, 2024
1 of 2 checks passed
@cmpadden cmpadden deleted the colton/daggy-u-dbt-1.7 branch July 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibsondan gibsondan gibsondan approved these changes

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmpadden @gibsondan