-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-dbt][DA] Add get_automation_condition method to DagsterDbtTranslator #23389
[dagster-dbt][DA] Add get_automation_condition method to DagsterDbtTranslator #23389
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @OwenKephart and the rest of your teammates on Graphite |
3044511
to
5047565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove get_auto_materialize_policy
and associated tests as well? We're removing those docs anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes for ^
5047565
to
f2ff0a3
Compare
@rexledesma I was keeping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, makes sense. we can wait to deprecate the other methods once AutomationCondition
becomes GA in 1.9.
…anslator (#23389) ## Summary & Motivation Adds a `get_automation_condition` method to DagsterDbtTranslator, and updates some docs references. ## How I Tested These Changes
Summary & Motivation
Adds a
get_automation_condition
method to DagsterDbtTranslator, and updates some docs references.How I Tested These Changes