Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compute log manager interface #23396

Closed
wants to merge 4 commits into from
Closed

remove compute log manager interface #23396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9e1a56
all remove old compute log
prha Aug 2, 2024
be7fc2e
patch tests
prha Aug 3, 2024
dbd1e5f
js schema
prha Aug 3, 2024
414e765
pyright
prha Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/dagster-plus/managing-deployments/controlling-logs.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Depending on your organization's needs, you may want to retain these logs in you

## Modifying compute log storage

Dagster's compute logs are handled by the configured [`ComputeLogManager`](/\_apidocs/internals#dagster.\_core.storage.compute_log_manager.ComputeLogManager). By default, Dagster+ utilizes the `CloudComputeLogManager` which stores logs in a Dagster+-managed Amazon S3 bucket, but you can customize this behavior to store logs in a destination of your choice.
Dagster's compute logs are handled by the configured [`CapturedLogManager`](/\_apidocs/internals#dagster.\_core.storage.captured_log_manager.CapturedLogManager). By default, Dagster+ utilizes the `CloudComputeLogManager` which stores logs in a Dagster+-managed Amazon S3 bucket, but you can customize this behavior to store logs in a destination of your choice.

### Writing to your own S3 bucket

Expand Down
4 changes: 0 additions & 4 deletions docs/sphinx/sections/api/apidocs/internals.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,6 @@ Compute log manager

.. autoclass:: CapturedLogManager

.. currentmodule:: dagster._core.storage.compute_log_manager

.. autoclass:: ComputeLogManager

.. currentmodule:: dagster._core.storage.local_compute_log_manager

.. autoclass:: LocalComputeLogManager
Expand Down
24 changes: 0 additions & 24 deletions js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

105 changes: 0 additions & 105 deletions js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions js_modules/dagster-ui/packages/ui-core/src/instance/types/useSupportsCapturedLogs.types.ts
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions js_modules/dagster-ui/packages/ui-core/src/instance/useSupportsCapturedLogs.tsx
View file
Open in desktop

This file was deleted.

Loading