Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sling] rm experimental decorator on SlingResource #23452

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[sling] rm experimental decorator on SlingResource #23452

merged 1 commit into from
Aug 6, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Aug 6, 2024

Summary & Motivation

  • remove experimental flag from SlingResource introduced in November, 2023

@cmpadden cmpadden merged commit 10b0761 into master Aug 6, 2024
1 check passed
@cmpadden cmpadden deleted the colton/sling-rm-experimental branch August 6, 2024 21:50
rexledesma
rexledesma reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, can we remove the deprecated methods from this library?

@cmpadden
Copy link
Contributor Author

cmpadden commented Aug 6, 2024 •
edited
Loading

While we're here, can we remove the deprecated methods from this library?

Sure, I'll throw together a follow-up.

Edit: PR here - #23461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexledesma rexledesma rexledesma left review comments

@PedramNavid PedramNavid PedramNavid approved these changes

@benpankow benpankow Awaiting requested review from benpankow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmpadden @PedramNavid @rexledesma