[ui] Automation polish #23466
Merged
[ui] Automation polish #23466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1750ed6. |
hellendag
force-pushed
the
dish/automation-polish
branch
from
7d44ec2 to
1750ed6
Compare
salazarm
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Some polish and cleanup for the merged automation page, which will now be turned on at
/automationfor users in the experimental navigation flag.For users in the navigation flag:
/automationto point at merged automations. All of the existing Automation root code (and schedules/sensors pages under it) is deleted here.For all users:
How I Tested These Changes
Verify that Backfills are now under Overview in all cases.
With nav flag turned on, verify that the top nav is correct and that navigating to "Automation" goes directly to the merged automation page. Verify that everything renders correctly there.