followup to "replace GrapheneAssetNode isSource with isMaterializable" #23490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sryza
changed the title
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2b763db. |
salazarm
approved these changes
Aug 8, 2024
sryza
force-pushed
the
is-source-after-fix
branch
from
c7d70f0 to
2b763db
Compare
|
Actually – thinking about this more deeply after noticing a test failure, I think the expected behavior is actually that we do want to hide the tab if the definition does not exist. So I'm going to close this without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I accidentally merged #23401 before fixing the bugs that @bengotow noticed. Here's a quick followup to fix.
How I Tested These Changes