[ui] Clean up Ops page #23647
Merged
[ui] Clean up Ops page #23647
+43
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 051bd99. |
PedramNavid
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Summary & Motivation Tidy up the old Ops page. - Replace react-virtualizer with tanstack virtualizer. - This is the last remaining `react-virtualizer` use case in the codebase, so I've removed it altogether. - Just show the name of the op in the scrollable list. The signature is redundant. - Clean up the selected state a bit. <img width="1262" alt="Screenshot 2024-08-14 at 10 22 10" src="https://github.com/user-attachments/assets/4364ea4f-2908-4322-b83f-1a4cee569fee"> ## How I Tested These Changes View Ops page for a code location with a bunch of ops. Verify that the list scrolls properly (and is virtualized properly) and that highlight state is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Tidy up the old Ops page.
react-virtualizeruse case in the codebase, so I've removed it altogether.How I Tested These Changes
View Ops page for a code location with a bunch of ops. Verify that the list scrolls properly (and is virtualized properly) and that highlight state is correct.