Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docathon] swizzle basic 404 #24034

Merged
merged 4 commits into from
Aug 29, 2024
Merged

[docathon] swizzle basic 404 #24034

merged 4 commits into from
Aug 29, 2024

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Aug 28, 2024

Summary & Motivation

yarn run swizzle @docusaurus/theme-classic NotFound                                                                                │
image

Edit: updated to include '404' and helpful links. It's lost some character, but we can always add a cool image later.

image image

Changelog [New | Bug | Docs]

NOCHANGELOG

@graphite-app graphite-app bot added docathon area: docs Related to documentation in general labels Aug 28, 2024
Copy link

graphite-app bot commented Aug 28, 2024

Graphite Automations

"docs-beta - Assign Reviewers" took an action on this PR • (08/28/24)

2 reviewers were added and 1 label was added to this PR based on Pedram Navid's automation.

Copy link
Contributor

Looks nice! I think it needs to say 404 Not Found somewhere.

image.png

image.png

Maybe have some references to other pages in the body?

Docs / Getting Started / Tutorial

@braunjj
Copy link
Contributor

braunjj commented Aug 28, 2024

Love it!

Copy link

github-actions bot commented Aug 29, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-b6ep36hyo-elementl.vercel.app

Direct link to changed pages:

@cmpadden
Copy link
Contributor Author

Looks nice! I think it needs to say 404 Not Found somewhere.

image.png

image.png

Maybe have some references to other pages in the body?

Docs / Getting Started / Tutorial

Updated it to include a stylized "404" along with some helpful links. Not as much cowboy character, but pretty clean.
image

But if you want I can add this failed generation of cowboy daggy.
image(2)

Copy link
Contributor

@PedramNavid PedramNavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it picasso

@cmpadden cmpadden merged commit 73bda51 into master Aug 29, 2024
3 checks passed
@cmpadden cmpadden deleted the docathon/basic-404 branch August 29, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general docathon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants