[docs-beta] Fix preview links in docs-revamp GH action #24046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
force-pushed
the
dish/test-gh-action
branch
5 times, most recently
from
98ab33b to
c0da124
Compare
hellendag
force-pushed
the
dish/test-gh-action
branch
2 times, most recently
from
8f85dd5 to
51e3188
Compare
hellendag
force-pushed
the
dish/test-gh-action
branch
from
51e3188 to
4adaf7e
Compare
hellendag
changed the title
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-a1jyr0ti9-elementl.vercel.app Direct link to changed pages: |
cmpadden
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The glob isn't finding md/mdx files properly. Not sure why, but if I just cd into the docs directory and use syntax like in the old docs action, it works.
How I Tested These Changes
Modify a
mdfile indocs-beta/docs, verify that the GH action posts a comment with the preview URL.Changelog [New | Bug | Docs]
NOCHANGELOG