[dagster-fivetran] Mark Fivetran legacy code as deprecated #26009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
Merged
[5/n][dagster-fivetran] Implement
FivetranWorkspaceData to FivetranConnectorTableProps method
#25797
Merged
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
78fe129 to
d3f1bf6
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
aacc6b9 to
77f6b7e
Compare
This was referenced Nov 20, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
d3f1bf6 to
b9e54d6
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
77f6b7e to
f7a858e
Compare
This was referenced Nov 21, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
b9e54d6 to
3aa72c9
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
f7a858e to
628596f
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
3aa72c9 to
3837589
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
628596f to
17d63d4
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
3837589 to
b417e4e
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
17d63d4 to
aebd36e
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
b417e4e to
3150e3e
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
aebd36e to
2946ac1
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
6fe328f to
c16e280
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
a896446 to
563ac54
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
c16e280 to
2df7622
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
563ac54 to
5981603
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
2 times, most recently
from
3317a7d to
b0e8961
Compare
|
Are we confirmed ready for this? We should not be marking any APIs as deprecated until the new APIs are out of experimental. |
dpeng817
requested changes
Dec 3, 2024
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
b0e8961 to
c94dc6b
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
5981603 to
e8ce934
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
c94dc6b to
36e9da9
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
e8ce934 to
eaa2d85
Compare
maximearmstrong
force-pushed
the
maxime/rework-fivetran-11
branch
from
36e9da9 to
99e73bd
Compare
maximearmstrong
force-pushed
the
maxime/mark-legacy-fivetran-code-deprecated
branch
from
eaa2d85 to
9055f55
Compare
|
The legacy code will be marked as superseded as part of the API lifecycle project, see here. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As title, to be deprecated in 2.0.
Changelog
[dagster-fivetran]
build_fivetran_assetsis marked as deprecated and will be removed in v2.0 in favor of thefivetran_assetsdecorator.[dagster-fivetran]
load_assets_from_fivetran_instanceis marked as deprecated and will be removed in v2.0 in favor of thebuild_fivetran_assets_definitionsfactory.[dagster-fivetran]
FivetranResourceis marked as deprecated and will be removed in v2.0 in favor of theFivetranWorkspaceresource.[dagster-fivetran] Fivetran ops are marked as deprecated and will be removed in v2.0 in favor of Fivetran assets.