[ui] Reject throttleLatest promise with a string instead of an Error #26452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 511230f. |
hellendag
force-pushed
the
dish/quiet-throttle-reject
branch
from
d98f3cd to
511230f
Compare
|
I think the actual issue is that the promise rejection was uncaught. |
salazarm
requested changes
Dec 13, 2024
|
Rejection catch should handle this as noted, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
When
throttleLatestrejects the Promise for an active call, use a string instead of anErrorto avoid surfacing unnecessary errors in our error tracking. Since the Promise rejection represents the function behaving as intended, theErrordoesn't need to be tracked or raise any alarms.How I Tested These Changes
Repro the Promise rejection case by viewing a Job dag that has surfaced it. Verify that an error appears in the console. Verify that with this change, no error is surfaced.