Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruff] 0.5.5 -> 0.8.4 #26666

Merged
merged 2 commits into from
Dec 22, 2024
Merged

[ruff] 0.5.5 -> 0.8.4 #26666

merged 2 commits into from
Dec 22, 2024

Conversation

smackesey
Copy link
Collaborator

@smackesey smackesey commented Dec 22, 2024

Internal companion PR: https://github.com/dagster-io/internal/pull/13147

Summary & Motivation

Upgrade ruff 0.5.5 -> 0.8.4.

Resulting changes from rules coming out of preview/bugfixes fall into a few categories:

  • __all__, __slots__ declarations are now alphabetized
  • parentheses are added around and expressions when chained with or:
x = a and b or c  # before
x = (a and b) or c  # after
  • TCH005 error code changed to TC005

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-c8n7ke8oy-elementl.vercel.app
https://sean-ruff-0-8-4.dagster.dagster-docs.io

Direct link to changed pages:

Copy link

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-cov7vy1e9-elementl.vercel.app

Direct link to changed pages:

@smackesey smackesey marked this pull request as ready for review December 22, 2024 14:27
@smackesey smackesey requested a review from neverett as a code owner December 22, 2024 14:27
@smackesey smackesey merged commit 3ea9100 into master Dec 22, 2024
3 checks passed
@smackesey smackesey deleted the sean/ruff-0.8.4 branch December 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants