Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-tableau] Use Tableau translator instance in spec loader and state-backed defs #26740

Open
wants to merge 2 commits into
base: maxime/move-translator-context-to-translator-props-class-tableau
Choose a base branch
from

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 27, 2024

Summary & Motivation

Same as #26734 but for Tableau.

How I Tested These Changes

BK

Changelog

[dagster-tableau] load_tableau_asset_specs is updated to accept an instance of DagsterTableauTranslator or custom subclass.

Copy link
Contributor Author

maximearmstrong commented Dec 27, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-tableau branch from f02a110 to 5fe42bb Compare December 27, 2024 19:49
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-tableau-asset-specs branch from 2721f82 to 2a268ea Compare December 27, 2024 19:49
@maximearmstrong maximearmstrong marked this pull request as ready for review December 27, 2024 20:05
@maximearmstrong maximearmstrong self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant