[5/n][dagster-sling] Update callsites with DagsterSlingTranslator.get_asset_spec #27167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-4
branch
from
c5ceba9 to
f881d04
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
47b221d to
b470f66
Compare
OwenKephart
approved these changes
Jan 17, 2025
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-4
branch
from
f881d04 to
dc036e5
Compare
maximearmstrong
force-pushed
the
maxime/sling-asset-spec-5
branch
from
b470f66 to
1ba176a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Update all
get_*callsites to useget_asset_spec(...)insteadHow I Tested These Changes
Updated tests with BK