Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy / aws-lambda / sst waku stack #913

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aheissenberger
Copy link
Contributor

This is a first draft for a sst stack for WAKU.

Based on the fact, that there can be more than 25 folders (AWS Cloudfront routing limit) on the first level of the public folder only the folder public/images and public/assets are copied to s3 and forward by CloudFront.

A possible, but more complex solution could handle this by adding a Cloudfunction to Cloudfront which knows all routes and can forward all existing static root level routes.

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2024 1:37am

@aheissenberger aheissenberger marked this pull request as draft September 28, 2024 01:19
@aheissenberger
Copy link
Contributor Author

@rmarscher this is based as suggested on the sst tanstack-start stack

Copy link

codesandbox-ci bot commented Sep 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@rmarscher
Copy link
Contributor

@rmarscher this is based as suggested on the sst tanstack-start stack

It looks great on a quick read. I'll try to test it next week. I wonder if we can get them to accept it upstream...

@rmarscher
Copy link
Contributor

I think SST refactored their SsrSite dev server code since this example was created. They might be moving too fast for this to be worthwhile to include here. They need a public SsrSite component that's easier to extend.

I also think it's a little bit better to move the public files out of the lambda bundle. I think we discussed that elsewhere. Waku doesn't have an option to output separate server dist folder from public dist folder. The public folder is inside the dist folder because the server code references some of the public assets. In the Cloudflare adapter, I separate them out. I'd like to make that a more standard build option that our adapters can opt into. We can refactor the build options to have more flexibility. Maybe I can find time to suggest some general build config edits in a PR. #806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants