Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldHub: Project deletion interface #187

Merged
merged 10 commits into from
Dec 19, 2023
Merged

FieldHub: Project deletion interface #187

merged 10 commits into from
Dec 19, 2023

Conversation

dersmon
Copy link
Member

@dersmon dersmon commented Dec 4, 2023

No description provided.

@dersmon dersmon added field_hub Issue concerning the Hub server elixir Tickets concerning Elixir Code, https://elixir-lang.org/ labels Dec 4, 2023
Copy link
Member Author

@dersmon dersmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some tests to project_show_live_test.exs for the new functionality.

@@ -42,6 +44,8 @@ defmodule FieldHubWeb.ProjectShowLive do
|> assign(:project, project)
|> assign(:current_user, user_name)
|> assign(:new_password, "")
|> assign(:confirm_project_name, "")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better named :repeated_project_name?

|> put_flash(:error, msg)
end

IO.inspect(delete_files)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@dersmon dersmon merged commit 461b54c into master Dec 19, 2023
2 checks passed
@dersmon dersmon deleted the deletion-interface branch January 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Tickets concerning Elixir Code, https://elixir-lang.org/ field_hub Issue concerning the Hub server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants