Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desktop.yml #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update desktop.yml #259

wants to merge 1 commit into from

Conversation

pushkar-hue
Copy link

Changed deprecated action to their update versions.

  1. actions/checkout@v3 -> actions/checkout@v4
  2. actions/node-setup@v3 -> actions/node-setup@v4
  3. node-version: 16 -> node-version: '16.x'
  4. c-hive/gha-npm-cache@v1 -> actions/cache@v3

Changed deprecated action to their update versions. 
1. actions/checkout@v3 -> actions/checkout@v4
2. actions/node-setup@v3 -> actions/node-setup@v4
3. node-version: 16 -> node-version: '16.x'
4. c-hive/gha-npm-cache@v1 -> actions/cache@v3
@lsteinmann
Copy link
Member

Hey @pushkar-hue , thanks for you contribution! This will close #257 . It doesn't run because GitHub switched to docker compose instead of docker-compose, so nothing to do with your change.

Just curious - why node '16.x' instead of just 16?

Also, https://github.com/c-hive/gha-npm-cache states that the functionality is part of actions/setup-node anyway - maybe something to checkout?

I'll leave this open for @tkleinke though, as he is the lead on Field Desktop.

@pushkar-hue
Copy link
Author

pushkar-hue commented Aug 12, 2024

Thank you for letting me contribute this was my first contribution.So, I apologies for any mistake on my part as I'm still learning. As of why '16.x' it just something i came across while reading about the workflow. This means if Node 16.20.1 is available the workflow will use that version instead of specifically 16.0.0 as it will provide more flexibility to bug check i added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants