Add flag to allow multiple prefix() sections to not be automatically sorted #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daixiang0
reviewed
Jul 8, 2024
|
@daixiang0 Force pushed to sign commits, let me know if any additional changes are required. Thanks |
|
Please fix DCO then we can make it land. |
Signed-off-by: DanWlker <[email protected]>
Signed-off-by: DanWlker <[email protected]>
Signed-off-by: DanWlker <[email protected]>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Sep 11, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/daixiang0/gci](https://redirect.github.com/daixiang0/gci) | `v0.13.4` -> `v0.13.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>daixiang0/gci (github.com/daixiang0/gci)</summary> ### [`v0.13.5`](https://redirect.github.com/daixiang0/gci/releases/tag/v0.13.5) [Compare Source](https://redirect.github.com/daixiang0/gci/compare/v0.13.4...v0.13.5) #### What's Changed - Add flag to allow multiple prefix() sections to not be automatically sorted by [@​DanWlker](https://redirect.github.com/DanWlker) in [https://github.com/daixiang0/gci/pull/210](https://redirect.github.com/daixiang0/gci/pull/210) - Update standard library list for go 1.23 by [@​silas](https://redirect.github.com/silas) in [https://github.com/daixiang0/gci/pull/214](https://redirect.github.com/daixiang0/gci/pull/214) #### New Contributors - [@​DanWlker](https://redirect.github.com/DanWlker) made their first contribution in [https://github.com/daixiang0/gci/pull/210](https://redirect.github.com/daixiang0/gci/pull/210) - [@​silas](https://redirect.github.com/silas) made their first contribution in [https://github.com/daixiang0/gci/pull/214](https://redirect.github.com/daixiang0/gci/pull/214) **Full Changelog**: daixiang0/gci@v0.13.4...v0.13.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Yang Song <[email protected]>
Zxilly
pushed a commit
to Zxilly/gci
that referenced
this pull request
Nov 11, 2024
…sorted (daixiang0#210) * Add no lex order for custom sections Signed-off-by: DanWlker <[email protected]> * Add tests Signed-off-by: DanWlker <[email protected]> * Invert check to decrease steps Signed-off-by: DanWlker <[email protected]> --------- Signed-off-by: DanWlker <[email protected]> Signed-off-by: Zxilly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command-line flag that, when enabled, skips sorting "prefix(" imports lexically, while still preserving the default sorting for other types of sections. By default the value is false so as to not change the default behavior of gci.
Fixes: #205