Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements and bugfix to allow editing files with minified sections. #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Various improvements and bugfix to allow editing files with minified sections. #35

wants to merge 8 commits into from

Conversation

init-js
Copy link

@init-js init-js commented Aug 13, 2016

Various improvements for usability of jshint-mode:

  • add a version of flymake-cursor as a convenience, which shows flymake errors in the minibuffer
  • also flymake-jshint .js.in files
  • flymake would choke on minified lines (emacs hangs on those lines if they have errors). hiding code from the linter error output (but keeping line no and column of errors) fixes that.
  • improve server usage string
  • log amount of time taken to lint input file
  • this pull request includes the dynamic port selection fix (another pull request).

init-js and others added 8 commits October 17, 2014 00:22
@init-js
[compat] Missing fs.existsSync on node v0.6.12
546d983 
   Patch fs to get missing existsSync.
@init-js
Support for multiple jshint-mode servers running in parallel (one per…
ccd1ef9 
… port)

  Allows multiple emacs programs to be open and benefit from jshint-mode
  at the same time. A server is started on the lowest unused port in the
  (configurable) range 3003 to 3100.

  The server gets a new argument --lastport INT. The flymake-hook filters
  stdout for the "Server started" message and extracts the port from there.
@init-js
[flymake cursor] Convenience tool to show flymake errors in minibuffer
dc4c300
@init-js
[coverage] Inspect .js.in files (preprocessed source files / autotools)
c73fae5
@init-js
[lint] Long line split
cff30e7
@init-js
[logging] Print amount of time (ms) taken to lint input file.
a44cfde
@init-js
[bugfix] Allow flymake to digest errors on long lines faster. (e.g. m…
2db42ca 
…inified sections)

  This adds an HTTP POST parameter called 'showCode' to enable/disable
  showing code evidence lines after each error line. Hiding error code
  snippets dramatically reduces the amount of data returned.

  Errors in minified content would cause the full line to be returned for
  each error. Flymake is slow at parsing content, in blocks of 4KiB, to the
  point where using jshint-mode on minified files or files with long lines
  caused emacs to hang.

  the default value for showCode is '0', hiding content.
@init-js
[documentation] Add server usage.
3dffa6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@init-js