Support pnp_model_id in the IoTHubClientBuilder #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support different configuration parameters, implement a builder pattern for IoTHubClient, that initially just supports the same parameters as IoTHubClient::new().
To use this library in an IoT Edge deployment we need to be able to set add root certificates to the trust store. See: https://docs.microsoft.com/en-us/azure/iot-edge/how-to-connect-downstream-device?view=iotedge-2020-11#provide-the-root-ca-certificate
As part of the plug-n-play (PNP) functionality, the IoTHubClient should be able to support announcing a model ID. The model ID must be a valid DTMI. The module introduced here implements validation for a string as a possible DTMI. See https://github.com/Azure/digital-twin-model-identifier
|
@damienpontifex Only the last two commits 05226a6 and f9d3f5d should be reviewed here.
|
laumann
force-pushed
the
builder-pnp-model-id
branch
from
f9d3f5d to
5e75b36
Compare
The idea with PNP is that connecting devices can announce a model ID which should be a valid DTMI when connecting. This functionality is only really supported for MQTT. The IoTHubClientBuilder accepts a str that it attempts to turn into a Dtmi instance which can only be constructed if it passes validation.
laumann
force-pushed
the
builder-pnp-model-id
branch
from
5e75b36 to
e52b5ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #61 - instead of adding
IoTHubClient::new_with_pnp(), add apnp_model_id()function to the new IoTHubClientBuilder.Depends on #62, #63