Fix queue #44
Closed
Fix queue #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed threadpool.h and it didn't rebuild. There are others, too. Signed-off-by: Rusty Russell <[email protected]>
I wondered by gdb was getting stuck! Suggested-by: jb55 Signed-off-by: Rusty Russell <[email protected]>
Will noted that the tests failed with a smaller queue, and this why. This fixes the problem and we add a "try" function next for when we don't want to block. Signed-off-by: Rusty Russell <[email protected]>
They're not worth inlining, and we're about to add some routines which aren't for public consumption. Signed-off-by: Rusty Russell <[email protected]>
1. Write generic routines to copy bytes in and out of ring buffer. 2. Write generic routines to pull/pull with/without blocking. 3. Implemented *_many and *_try functions in these terms. Signed-off-by: Rusty Russell <[email protected]>
|
Something else is wrong, closing for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jb55 told me that shrinking the queue caused deadlock, and indeed it does: mainly because we discard on inserting to a full queue. The code itself was a bit baroque, but working.