Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize thread multi subscribe #287

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Generalize thread multi subscribe #287

merged 2 commits into from
Sep 26, 2024

Conversation

kernelkind
Copy link
Contributor

@kernelkind kernelkind commented Sep 4, 2024 •
edited
Loading

closes #276

@kernelkind
Copy link
Contributor Author

minimally extracts the local/remote conception that was in Thread into MultiSubscriber. Will be useful for upcoming ProfileView and other objects in the future which will need multi subscriptions

@kernelkind
Copy link
Contributor Author

kernelkind commented Sep 18, 2024 •
edited
Loading

Demonstration that threads still work:

output_generalize_2.mov

I had to drop the thread hitbox stuff to be able to do this demonstration, but as you can see threads seem to work still

@jb55 jb55 merged commit 6c94987 into damus-io:master Sep 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize thread subscriptions
2 participants
@kernelkind @jb55