Note more options #318
Merged
Note more options #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kernelkind <[email protected]>
egui doesn't support custom buttons so `stationary_arbitrary_menu_button` had to be hacked together Signed-off-by: kernelkind <[email protected]>
forgot to add this part Signed-off-by: kernelkind <[email protected]>
jb55
added a commit
that referenced
this pull request
Sep 26, 2024
This merges kernel's note context menu with a bunch of refactorings on top, closing #328 and #318 William Casarin (7): refactor: remove processs_note_selection refactor: make options_button a NoteOptions note: switch to muted menu_options_button color context: move note context button to its own file context: fix hitbox, float on far right context: set cursor icon on hover kernelkind (3): Add 'more options' to each note can left click note more options button process 'more options' for previews
|
Merged with fixes at 13d6873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds three dots 'more options' button to each note. When clicked, it shows a more options context menu. Right now there are three options, each of which copy things to the system's clipboard