Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note context menu refactoring #328

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Note context menu refactoring #328

merged 9 commits into from
Sep 26, 2024

Commits on Sep 19, 2024

  1. Add 'more options' to each note 

    Signed-off-by: kernelkind <[email protected]>
    @kernelkind
    kernelkind committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6f5f090 View commit details
    Browse the repository at this point in the history

  2. can left click note more options button 

    egui doesn't support custom buttons so
`stationary_arbitrary_menu_button` had to be hacked together

Signed-off-by: kernelkind <[email protected]>
    @kernelkind
    kernelkind committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ad319b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. process 'more options' for previews 

    forgot to add this part

Signed-off-by: kernelkind <[email protected]>
    @kernelkind
    kernelkind committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    171889b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. refactor: remove processs_note_selection 

    Moved this to NoteOptionSelection::process

Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1a94c21 View commit details
    Browse the repository at this point in the history

  2. refactor: make options_button a NoteOptions 

    No reason why this needs to be a standalone bool

Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a9cb734 View commit details
    Browse the repository at this point in the history

  3. note: switch to muted menu_options_button color 

    Otherwise it stands out too much

Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0c3b2ae View commit details
    Browse the repository at this point in the history

  4. context: move note context button to its own file 

    Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2dba411 View commit details
    Browse the repository at this point in the history

  5. context: fix hitbox, float on far right 

    This updates the context menu to "float" instead of using the layout
engine. This is so that we don't take up an unnecessary amount of space
when we increase the hitbox height.

Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5120686 View commit details
    Browse the repository at this point in the history

  6. context: set cursor icon on hover 

    So we know its clickable. I mean the animation signals that as well, but
still.

Signed-off-by: William Casarin <[email protected]>
    @jb55
    jb55 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d416044 View commit details
    Browse the repository at this point in the history