Integrate sidebar #80
Conversation
|
Run |
|
let's not merge master into this, I will rebase it |
Signed-off-by: kernelkind <[email protected]> Signed-off-by: William Casarin <[email protected]>
Create a side panel UI element for desktop with three buttons for: adding a column, settings, and account management. The account management button is temporary pending a better design. It is the only one that is interactable at the moment. When the user clicks it, the global popup window will be shown and the AccountManagementView will be presented on the window. The user can click on the X on the top right of the window to close it. Signed-off-by: kernelkind <[email protected]> Signed-off-by: William Casarin <[email protected]>
Signed-off-by: kernelkind <[email protected]> Signed-off-by: William Casarin <[email protected]>
Signed-off-by: kernelkind <[email protected]> Signed-off-by: William Casarin <[email protected]>
we can just get this from the egui::Ui when rendering Signed-off-by: William Casarin <[email protected]>
buttons don't do anything yet Signed-off-by: William Casarin <[email protected]>
also use IdTypeMap::insert_temp instead of insert_persisted. The whole conception of using egui memory to share state is probably going to be changed to a more robust solution in the future. Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
|
see |
|
all this will need to be refactored. There is too much global state everywhere, and many of the components are needlessly touching global state when they can simply return individual responses. I will start on this refactoring to show what I mean. ideally don't do any more work on this branch until we get this sorted. |
Signed-off-by: William Casarin <[email protected]>
We should be treating all ui widgets as pure functions that do not mutate anything. This will make testing easier, as well as avoiding shared mutable references. Signed-off-by: William Casarin <[email protected]>
|
I'm happy the state this is in for now, even if the sidebar is non-functional. We have click handling states at least! Wanted to merge this since there are a bunch of changes and I don't want this to get too out of sync with master. Working on nav so that we can re-add the global popup. |
This follows from:
It hooks up the sidebar into our UI, but we still need to make the buttons work and implement a design: