Enable trailing delete in production #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
enable-trailing-delete-prod
branch
from
9cd08b4
to
733a3fc
Compare
yarikoptic
reviewed
Oct 9, 2024
| @@ -17,7 +16,6 @@ module "sponsored_embargo_bucket" { | |||
| source = "./modules/dandiset_bucket" | |||
| bucket_name = "dandiarchive-embargo" | |||
| versioning = false | |||
| trailing_delete = false | |||
| heroku_user = data.aws_iam_user.api | |||
| log_bucket_name = "dandiarchive-embargo-logs" | |||
| providers = { | |||
There was a problem hiding this comment.
Given that this month-old PR is still a draft, I would like right away to adjust policies here to exclude /zarr/ prefix from trailing delete functionality -- we do want to keep prior versionIds even after DeleteMarker is added.
What would that entail?
Ref:
There was a problem hiding this comment.
I've opened a PR to address this (#190). Once that's merged, this PR will be unblocked.
|
@mvandenburgh could you please add into original description a list of TODOs for this PR to be accomplished for it to come out of Draft and be merged/deployed. |
mvandenburgh
force-pushed
the
enable-trailing-delete-prod
branch
from
733a3fc
to
f689629
Compare
jjnesbitt
approved these changes
Oct 28, 2024
An error occurred while trying to automatically change base from
scoped-lifecycle-policy
to
master
October 28, 2024 19:26
mvandenburgh
force-pushed
the
enable-trailing-delete-prod
branch
from
f689629
to
32cade8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements before merging this PR
blobsprefix only #190 and rebase this PR on master