Reduce the sizes of a number of streams & futures #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the sizes of many Futures by 3520 bytes each.
The net savings from this commit are 64 bytes each for various Future types. It's not much, but I feel the code also looks cleaner now.
This reduces the sizes of many Futures by 4720 bytes each.
This reduces the sizes of various Futures by 808 bytes each.
This reduces the sizes of various Futures by 2192 bytes each.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 48.35% 46.47% -1.88%
==========================================
Files 24 27 +3
Lines 3671 3819 +148
==========================================
Hits 1775 1775
- Misses 1896 2044 +148 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By replacing
async_streamwith a combination of "manually implemented" streams and various stream combinators, along with some other changes, this PR considerably reduces the sizes of a number of stream & future types used bydandidav. In particular, the future forDandiDav::inner_handle_request()— previously the largest type in thedandidavcode proper — went from 17104 bytes to 5784 bytes.