Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out "validated string" boilerplate #68

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Factor out "validated string" boilerplate #68

merged 5 commits into from
Feb 13, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 13, 2024

No description provided.

@jwodder jwodder added the code quality Nonfunctional improvements to the codebase label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (e1dd589) 34.71% compared to head (93b2cba) 35.57%.

Files Patch % Lines
src/validstr.rs 70.12% 23 Missing ⚠️
src/paths/component.rs 55.00% 9 Missing ⚠️
src/dandi/version_id.rs 63.15% 7 Missing ⚠️
src/paths/dirpath.rs 70.00% 6 Missing ⚠️
src/paths/purepath.rs 70.00% 6 Missing ⚠️
src/zarrman/resources.rs 0.00% 5 Missing ⚠️
src/s3.rs 0.00% 3 Missing ⚠️
src/dandi/dandiset_id.rs 66.66% 2 Missing ⚠️
src/dandi/mod.rs 0.00% 2 Missing ⚠️
src/dav/types.rs 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   34.71%   35.57%   +0.86%     
==========================================
  Files          23       24       +1     
  Lines        3365     3320      -45     
==========================================
+ Hits         1168     1181      +13     
+ Misses       2197     2139      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder merged commit 19da772 into main Feb 13, 2024
10 checks passed
@jwodder jwodder deleted the validstr branch February 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Nonfunctional improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant