Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to version & asset metadata to web view #76

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Add links to version & asset metadata to web view #76

merged 6 commits into from
Feb 15, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 14, 2024

Closes #13.

@jwodder jwodder added enhancement New feature or request therefor ui:web Relating to the web interface labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 125 lines in your changes are missing coverage. Please review.

Comparison is base (4998bd8) 36.71% compared to head (79f8578) 35.99%.

Files Patch % Lines
src/dandi/mod.rs 0.00% 52 Missing ⚠️
src/dandi/types.rs 0.00% 50 Missing ⚠️
src/dav/types.rs 0.00% 16 Missing ⚠️
src/dav/mod.rs 0.00% 4 Missing ⚠️
src/dav/html.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   36.71%   35.99%   -0.72%     
==========================================
  Files          24       24              
  Lines        3435     3503      +68     
==========================================
  Hits         1261     1261              
- Misses       2174     2242      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Feb 14, 2024

Current status: At first, the metadata links looked like this:

Screenshot 2024-02-14 at 16 31 43

(Page source: https://gist.github.com/jwodder/47b7d85ab38f5d04da0eb509e82ebe45)

Then, I used flex boxes to align the links on the right of their containing cells, and that worked, but it also caused the left & bottom borders of the "Name" column to be darker than the rest of the table borders:

Screenshot 2024-02-14 at 16 33 48

(Page source: https://gist.github.com/jwodder/6e3bdf1abb8c944e5564ad3308f9cd7e)

I don't like this, and I can't figure out how to fix it.

@jwodder jwodder mentioned this pull request Feb 15, 2024
@jwodder jwodder marked this pull request as ready for review February 15, 2024 20:19
@jwodder jwodder merged commit bfc7ffe into main Feb 15, 2024
8 of 10 checks passed
@jwodder jwodder deleted the gh-13 branch February 15, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request therefor ui:web Relating to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show links to version & asset metadata in web view
1 participant