Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat load groups by id kc 22 #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat load groups by id kc 22 #135

wants to merge 3 commits into from

Conversation

petrisorcibian
Copy link

No description provided.

@daniel-frak
Copy link
Owner

Hello!

Sorry for such a late reply, I didn't notice the open PR.

Could you elaborate a bit on the need for these changes?

From what I see, it seems to just be adding case-insensitivity to logins and renaming groupName to groupId.

  1. In the case of case-insensitivity, I think this should be an optional configuration which defaults to false.
  2. In the case of renaming groupName to groupId, could you tell me why? Did something change in Keycloak's interfaces?

@abdurrahmanekr abdurrahmanekr mentioned this pull request Mar 24, 2024
Open
@daniel-frak daniel-frak added the question Further information is requested label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrisorcibian @daniel-frak @claudiunicolaa