[WIP] add other platforms to CI.

.github/workflows/unit-test.yml

@@ -12,14 +12,20 @@ on:
 jobs:
   build:
 
-    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        platform: [ubuntu-latest, macos-latest, windows-latest]
+        python-version: [3.7]
+
+    runs-on: ${{ matrix.platform }}
 
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Python 3.7
+    - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
       with:
-        python-version: 3.7
+        python-version: ${{ matrix.python-version }}
     - name: Set up JDK 1.8
       uses: actions/setup-java@v1
       with:
@@ -28,7 +34,8 @@ jobs:
       run: |
         python -m pip install --upgrade pip
         pip install flake8
-        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+        pip install -e .
+        python -m spacy download en_core_web_sm
 
     - name: Cache AutoSummENG
       id: cache-autosummeng

sacrerouge/metrics/meteor.py

@@ -1,6 +1,9 @@
 import argparse
 import logging
 import os
+import requests
+import tarfile
+from pathlib import Path
 from collections import defaultdict
 from overrides import overrides
 from subprocess import Popen, PIPE
@@ -36,6 +39,7 @@ def _flatten_summaries(self, summaries_list: List[List[SummaryType]]) -> List[Li
 
     def _parse_meteor_stdout(self, stdout: str) -> Tuple[float, List[float]]:
         lines = stdout.splitlines()
+        print(lines)
         assert lines[11].startswith('Segment 1 score'), 'Unexpected Meteor stdout format'
 
         individual_scores = []
@@ -133,17 +137,20 @@ def add_subparser(self, parser: argparse._SubParsersAction):
 
     @overrides
     def run(self, args):
-        commands = [
-            f'mkdir -p {DATA_ROOT}/metrics/METEOR',
-            f'cd {DATA_ROOT}/metrics/METEOR',
-            f'wget https://www.cs.cmu.edu/~alavie/METEOR/download/meteor-1.5.tar.gz',
-            f'tar xzvf meteor-1.5.tar.gz'
-        ]
-        command = ' && '.join(commands)
-
-        process = Popen(command, shell=True)
-        process.communicate()
-        if process.returncode == 0:
-            print('METEOR setup success')
-        else:
-            print('METEOR setup failure')
+        output_dir = Path(f'{DATA_ROOT}/metrics/METEOR')
+        output_dir.mkdir(exist_ok=True, parents=True)
+
+        output_file = output_dir / 'meteor-1.5.tar.gz'
+
+        if not output_file.exists():
+            r = requests.get('https://www.cs.cmu.edu/~alavie/METEOR/download/meteor-1.5.tar.gz', stream=True)
+
+            if r.status_code != 200:
+                print('METEOR setup failure.')
+                return
+            with open(output_file, 'wb') as f:
+                for chunk in r.iter_content(1024):
+                    f.write(chunk)
+        with tarfile.open(output_file, 'r:gz') as f:
+            f.extractall(path=output_dir)
+        print('METEOR setup success')

sacrerouge/metrics/rouge.py

@@ -1,7 +1,9 @@
 import argparse
 import logging
+import zipfile
 import os
 import sys
+from pathlib import Path
 from collections import defaultdict
 from overrides import overrides
 from subprocess import Popen, PIPE
@@ -250,19 +252,15 @@ def run(self, args):
             # No idea -- default to Linux
             file_id = '1K4J2wHGjAyr3LoSgaQuWZ_YyjtUGf26m'
 
-        download_file_from_google_drive(file_id, f'{DATA_ROOT}/metrics/ROUGE-1.5.5.zip')
 
-        commands = [
-            f'cd {DATA_ROOT}/metrics',
-            f'unzip ROUGE-1.5.5.zip',
-            f'rm ROUGE-1.5.5.zip'
-        ]
-        command = ' && '.join(commands)
+        output_dir = Path(f'{DATA_ROOT}/metrics')
+        output_file = output_dir / 'ROUGE-1.5.5.zip'
+
+        if not output_file.exists():
+            download_file_from_google_drive(file_id, output_file)
 
-        process = Popen(command, shell=True)
-        process.communicate()
-        if process.returncode != 0:
-            print('ROUGE setup failure')
+        with zipfile.ZipFile(output_file) as f:
+            f.extractall(output_dir)
 
         # ROUGE has data files which may not successfully load. Therefore, if it fails to run on a simple example,
         # the user needs to run some perl code within the ROUGE directory to correct the data file

setup.py

@@ -27,6 +27,7 @@
         'pytest',
         'requests',
         'scipy>=1.5.2',
-        'networkx'
+        'networkx',
+        'spacy~=2.2'
     ]
 )