Adds basename tests from The Ruby Spec Suite #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
changed the title
This ports the basename tests over from RubySpec (which uses MSpec instead of MiniTest). Some of these tests are failing.
glebm
force-pushed
the
basename-rubyspec-port
branch
from
eb5b387 to
1dd8d99
Compare
It sounds like a good idea. How much work would that be do you think? |
|
@danielpclark It's not a lot of work, except currently the sledge-hammered version prevents Bundler from parsing the lockfile and I don't know why. #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the basename tests over from RubySpec (which uses MSpec instead of MiniTest).
Some of these tests are failing.
Perhaps this project should run RubySpec directly? E.g. RubySpec repo could be a submodule, and rake could invoke a ruby command that monkey-patches everything and runs certain tests.