add sarama metrics

README.md

@@ -110,6 +110,7 @@ This image is configurable using different flags
 | web.telemetry-path           | /metrics   | Path under which to expose metrics                                                                  |
 | log.level                    | info       | Only log messages with the given severity or above. Valid levels: [debug, info, warn, error, fatal] |
 | log.enable-sarama            | false      | Turn on Sarama logging                                                                              |
+| metric.disable-sarama        | true       | Whether to disable sarama monitoring metrics or not                                                 |                                                                             |
 
 ### Notes
 

go.mod

@@ -5,24 +5,15 @@ go 1.16
 require (
 	github.com/Shopify/sarama v1.28.0
 	github.com/alecthomas/units v0.0.0-20210208195552-ff826a37aa15 // indirect
-	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/eapache/go-xerial-snappy v0.0.0-20180814174437-776d5712da21 // indirect
-	github.com/eapache/queue v1.1.0 // indirect
+	github.com/deathowl/go-metrics-prometheus v0.0.0-20200518174047-74482eab5bfb
 	github.com/golang/protobuf v1.5.2 // indirect
-	github.com/google/go-querystring v1.1.0 // indirect
 	github.com/krallistic/kazoo-go v0.0.0-20170526135507-a15279744f4e
-	github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
 	github.com/pkg/errors v0.9.1
-	github.com/pkg/profile v1.2.1 // indirect
 	github.com/prometheus/client_golang v1.10.0
 	github.com/prometheus/common v0.25.0
-	github.com/prometheus/procfs v0.6.0 // indirect
-	github.com/prometheus/promu v0.12.0 // indirect
 	github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475
 	github.com/xdg/scram v0.0.0-20180814205039-7eeb5667e42c
 	golang.org/x/net v0.0.0-20210525063256-abc453219eb5 // indirect
-	golang.org/x/oauth2 v0.0.0-20210514164344-f6687ab2804c // indirect
 	golang.org/x/sys v0.0.0-20210521203332-0cec03c779c1 // indirect
-	google.golang.org/appengine v1.6.7 // indirect
 	gopkg.in/alecthomas/kingpin.v2 v2.2.6
 )

kafka_exporter.go

@@ -15,6 +15,7 @@ import (
 	"time"
 
 	"github.com/Shopify/sarama"
+	prometheusmetrics "github.com/deathowl/go-metrics-prometheus"
 	"github.com/krallistic/kazoo-go"
 	"github.com/pkg/errors"
 	"github.com/prometheus/client_golang/prometheus"
@@ -78,6 +79,7 @@ type kafkaOpts struct {
 	uriZookeeper             []string
 	labels                   string
 	metadataRefreshInterval  string
+	disableMetrics            bool
 }
 
 // CanReadCertAndKey returns true if the certificate and key files already exists,
@@ -526,6 +528,7 @@ func main() {
 	kingpin.Flag("zookeeper.server", "Address (hosts) of zookeeper server.").Default("localhost:2181").StringsVar(&opts.uriZookeeper)
 	kingpin.Flag("kafka.labels", "Kafka cluster name").Default("").StringVar(&opts.labels)
 	kingpin.Flag("refresh.metadata", "Metadata refresh interval").Default("30s").StringVar(&opts.metadataRefreshInterval)
+	kingpin.Flag("metric.disable-sarama", "Whether to disable sarama monitoring metrics or not").Default("true").BoolVar(&opts.disableMetrics)
 
 	plog.AddFlags(kingpin.CommandLine)
 	kingpin.Version(version.Print("kafka_exporter"))
@@ -655,6 +658,12 @@ func setup(
 		plog.Fatalln(err)
 	}
 	defer exporter.client.Close()
+	if !opts.disableMetrics {
+		metrics.UseNilMetrics = false
+		prometheusClient := prometheusmetrics.NewPrometheusProvider(exporter.client.Config().MetricRegistry, "sarama", "kafka", prometheus.DefaultRegisterer, 1*time.Second)
+		go prometheusClient.UpdatePrometheusMetrics()
+		// prometheusClient.UpdatePrometheusMetricsOnce()
+	}
 	prometheus.MustRegister(exporter)
 
 	http.Handle(metricsPath, promhttp.Handler())