Added extra check_allowed_headers kludge for Accept request header #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,6 +125,9 @@ check_allowed_headers([<<"origin">>|Tail], Allowed, Req, State) -> | |||
| %% header underpins the entire CORS framework, its inclusion in | |||
| %% the requested headers is nonsensical. | |||
| check_allowed_headers(Tail, Allowed, Req, State); | |||
| check_allowed_headers([<<"accept">>|Tail], Allowed, Req, State) -> | |||
| %% KLUDGE: for browsers that include this header. | |||
| check_allowed_headers(Tail, Allowed, Req, State); | |||
There was a problem hiding this comment.
If I recall correctly, the prior deals with Safari always requesting the Origin header, no matter what the client does. Is there a case of any browsers doing the same for Accept header?
Perhaps a slightly less restrictive default for allowed_headers when it isn't defined would be more appropriate (e.g. Accept and Content-Type)?
There was a problem hiding this comment.
Sorry it's gone out of my mind now :) reading around at the time, it seemed that browser handling of CORS was changing rapidly. Perhaps kludges - and/or less restrictive defaults - are appropriate until/unless things settle.
|
Thanks for the PR, @llaisdy, I'm really sorry I didn't notice this sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome adds an "accept" value to the Access-Control-Request-Headers request header. This was causing termination of the request.
I've added a kludge/check for this (same as the "origin" kludge/check) to cowboy_cors:check_allowed_headers/4.
Thanks
Ivan
p.s. Thanks v much for cowboy_cors!