Skip to content

Commit

Permalink
Fix respecting serverapp.terminals_enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
danielzgtg committed Oct 5, 2023
1 parent 1f31c94 commit b8aa604
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions jupyter_server_terminals/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ class TerminalsExtensionApp(ExtensionApp):

def initialize_settings(self) -> None:
"""Initialize settings."""
if not self.serverapp.terminals_enabled:
return
self.initialize_configurables()
self.settings.update(
{"terminals_available": True, "terminal_manager": self.terminal_manager}
Expand Down Expand Up @@ -70,6 +72,9 @@ def initialize_configurables(self) -> None:

def initialize_handlers(self) -> None:
"""Initialize handlers."""
if not self.serverapp.terminals_enabled:
# Checking self.terminals_available instead breaks enabling terminals
return
self.handlers.append(
(
r"/terminals/websocket/(\w+)",
Expand Down

0 comments on commit b8aa604

Please sign in to comment.