Skip to content

Commit

Permalink
Merge pull request #138 from dmitriim/issue137
Browse files Browse the repository at this point in the history
issue #137: fix broken filters for h5pactivity_attempts
  • Loading branch information
danmarsden authored Nov 27, 2023
2 parents a5465e3 + 29b9d37 commit 1fc718e
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion classes/reportbuilder/entities/h5pactivity_attempts.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ public function initialise(): base {
$this->add_column($column);
}

foreach ($this->get_all_filters() as $filter) {
$this->add_filter($filter)->add_condition($filter);
}

return $this;
}

Expand Down Expand Up @@ -209,7 +213,7 @@ protected function get_all_filters(): array {
$filters[] = (new filter(
select::class,
'success',
new lang_string('outcome', 'local_recompletion'),
new lang_string('outcome', 'h5pactivity'),
$this->get_entity_name(),
"{$alias}.success"
))
Expand Down

0 comments on commit 1fc718e

Please sign in to comment.